test(firestore): compile once and reuse build artifacts in npm test#8765
Open
dlarocque wants to merge 1 commit into
Open
test(firestore): compile once and reuse build artifacts in npm test#8765dlarocque wants to merge 1 commit into
dlarocque wants to merge 1 commit into
Conversation
dlarocque
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the test script in handwritten/firestore/package.json to run compilation and test commands directly. The reviewer noted that the pretest-only and preconformance hooks were not removed as stated in the PR description, and suggested reusing existing npm scripts in the test command to improve maintainability and avoid duplication.
Previously, running npm test triggered test-only and conformance scripts, each with pre hooks that wiped and recompiled the build directory. This resulted in compiling the entire codebase twice per test run. This change removes pretest-only and preconformance hooks, updating npm test to compile once and execute unit and conformance tests sequentially against the shared build directory.
dlarocque
force-pushed
the
optimize-npm-test
branch
from
f4f2c3f to
e86799c
Compare
MarkDuckworth
approved these changes
Jun 26, 2026
product-auto-label
Bot
added
the
api: firestore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, running npm test triggered test-only and conformance scripts, each with pre hooks that wiped and recompiled the build directory. This resulted in compiling the entire codebase twice per test run.
This change removes pretest-only and preconformance hooks, updating npm test to compile once and execute unit and conformance tests sequentially against the shared build directory.