test: no need to exclude kokoro owlbot files#8764
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates an example in the Kokoro trampoline script and adds several system test configuration files to the staging exclusion list in owlbot.py. However, the feedback highlights a contradiction: the code changes add these files to the exclusion list, which goes against the PR's stated objective of not excluding them.
| "system-test/fixtures/sample/src/index.ts", | ||
| ".kokoro/system-test.sh", | ||
| ".kokoro/continuous/node14/system-test.cfg", | ||
| ".kokoro/presubmit/node14/system-test.cfg"], |
There was a problem hiding this comment.
The pull request title and description indicate that it is unnecessary to exclude these files. However, this change actually adds '.kokoro/system-test.sh' and the configuration files to the 'staging_excludes' list, which does the opposite of the stated goal. If these files do not need to be excluded, they should not be added here.
"system-test/fixtures/sample/src/index.ts"],There was a problem hiding this comment.
This was pushed too early. These changes are gone now.
danieljbruce
changed the title
danieljbruce
changed the title
1 participant
Description
Previously, #8761 was merged to remove the logging tests for kokoro, but it is also unnecessary to exclude the
.kokorofiles in owlbot.Impact
Just cleans up the tests a bit