test: remove kokoro system tests for bigquery-storage#8760
test: remove kokoro system tests for bigquery-storage#8760danieljbruce wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes Kokoro system test configuration files and the system-test.sh script, updating the OwlBot configuration to exclude the deleted script from template regeneration. The reviewer suggested also adding the deleted .cfg files to templates_excludes in owlbot.py to prevent OwlBot from regenerating them in future runs.
| templates_excludes=[ | ||
| 'src/index.ts', | ||
| 'README.md', | ||
| '.kokoro/system-test.sh' | ||
| ] |
There was a problem hiding this comment.
Since you are removing the Kokoro system test configuration files (.kokoro/continuous/node18/system-test.cfg and .kokoro/presubmit/node18/system-test.cfg), they should also be added to templates_excludes to prevent OwlBot from regenerating them during the next run.
templates_excludes=[
'src/index.ts',
'README.md',
'.kokoro/system-test.sh',
'.kokoro/continuous/node18/system-test.cfg',
'.kokoro/presubmit/node18/system-test.cfg'
]There was a problem hiding this comment.
I pushed an update to address this issue.
There was a problem hiding this comment.
Does owlbot actually generate these or are they entirely handwritten?
There was a problem hiding this comment.
I'm pretty sure system-test.sh is handwritten because it varies from library to library. It is probably okay to remove these from the excludes array.
Description
#8697 added the CI check to run bigquery-storage system tests in GCB so now we don't need to run the system tests in kokoro anymore. This pull request removes the CI check to run system tests from the kokoro environment because it is now redundant.
Impact
Removes redundant testing to save resources.
Files changed