Skip to content

test: remove kokoro system tests for pubsub#8758

Open
danieljbruce wants to merge 4 commits into
mainfrom
remove-kokoro-tests-pubsub
Open

test: remove kokoro system tests for pubsub#8758
danieljbruce wants to merge 4 commits into
mainfrom
remove-kokoro-tests-pubsub

Conversation

@danieljbruce

@danieljbruce danieljbruce commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

#8362 added the CI check to run pubsub system tests in GCB so now we don't need to run the system tests in kokoro anymore. This pull request removes the CI check to run system tests from the kokoro environment because it is now redundant.

Impact

Removes redundant testing to save resources.

Files changed

  • Removes the system-test.cfg files so that kokoro doesn't try to run system-test.sh from continuous or presubmit environments.
  • Removes the system-test.sh file as it will not be used anymore now that the config files are gone
  • trampoline_v2.sh example refers to samples-test.sh instead since system-test.sh doesn't exist anymore

This change removes the Kokoro configuration files and scripts for system tests in the pubsub handwritten library, aligning it with the bigtable library's configuration. Local system tests and other CI environments remain unaffected.
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the Pub/Sub API. label Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Kokoro system test configuration and the associated system-test.sh script. It also updates a comment in trampoline_v2.sh to reference samples-test.sh instead of the deleted script. There are no review comments, so I have no feedback to provide.

@danieljbruce danieljbruce changed the title chore(pubsub): remove Kokoro system tests for handwritten library test: remove kokoro system tests for pubsub Jun 25, 2026
@danieljbruce danieljbruce marked this pull request as ready for review June 25, 2026 19:58
@danieljbruce danieljbruce requested a review from a team as a code owner June 25, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant