Skip to content

test: remove kokoro system tests for datastore#8757

Open
danieljbruce wants to merge 4 commits into
mainfrom
remove-kokoro-tests-datastore
Open

test: remove kokoro system tests for datastore#8757
danieljbruce wants to merge 4 commits into
mainfrom
remove-kokoro-tests-datastore

Conversation

@danieljbruce

@danieljbruce danieljbruce commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

#8343 added the CI check to run datastore system tests in GCB so now we don't need to run the system tests in kokoro anymore. This pull request removes the CI check to run system tests from the kokoro environment because it is now redundant.

Impact

Removes redundant testing to save resources.

Files changed

  • Removes the system-test.cfg files so that kokoro doesn't try to run system-test.sh from continuous or presubmit environments.
  • Removes the system-test.sh file as it will not be used anymore now that the config files are gone
  • trampoline_v2.sh example refers to samples-test.sh instead since system-test.sh doesn't exist anymore
  • owlbot.py doesn't need to pay any attention to system-test.sh file and other removed files anymore

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes Kokoro system test configurations and scripts, and updates owlbot.py to exclude system-test.sh from being copied. The reviewer recommends also adding the deleted system-test.cfg files to the excludes list in owlbot.py to prevent OwlBot from recreating them on future runs.

Comment thread handwritten/datastore/owlbot.py Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@danieljbruce danieljbruce marked this pull request as ready for review June 25, 2026 19:40
@danieljbruce danieljbruce requested a review from a team as a code owner June 25, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant