chore: onboard google-cloud-functions to librarian#8755
Draft
quirogas wants to merge 1 commit into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the skip_generate: true flag from librarian.yaml, deletes an OwlBot configuration file, and updates the repository metadata for the Google Cloud Functions package. Feedback suggests removing an unnecessary empty line left in librarian.yaml and reverting the formatting of .repo-metadata.json to 2-space indentation while restoring the deleted codeowner_team and requires_billing fields.
Comment on lines
1
to
+16
| { | ||
| "issue_tracker": "", | ||
| "distribution_name": "@google-cloud/functions", | ||
| "product_documentation": "https://cloud.google.com/functions", | ||
| "api_id": "cloudfunctions.googleapis.com", | ||
| "client_documentation": "https://cloud.google.com/nodejs/docs/reference/functions/latest", | ||
| "repo": "googleapis/google-cloud-node", | ||
| "release_level": "stable", | ||
| "requires_billing": false, | ||
| "name_pretty": "Google Cloud Functions", | ||
| "name": "nodejs-functions", | ||
| "codeowner_team": "@googleapis/aap-dpes", | ||
| "default_version": "v1", | ||
| "language": "nodejs", | ||
| "api_shortname": "cloudfunctions", | ||
| "library_type": "GAPIC_AUTO" | ||
| } | ||
| "api_description": "Manages lightweight user-provided functions executed in response to events.", | ||
| "api_id": "cloudfunctions.googleapis.com", | ||
| "api_shortname": "cloudfunctions", | ||
| "client_documentation": "https://cloud.google.com/nodejs/docs/reference/functions/latest", | ||
| "default_version": "v1", | ||
| "distribution_name": "@google-cloud/functions", | ||
| "issue_tracker": "https://issuetracker.google.com/savedsearches/559729", | ||
| "language": "nodejs", | ||
| "library_type": "GAPIC_AUTO", | ||
| "name": "cloudfunctions", | ||
| "name_pretty": "Cloud Functions", | ||
| "product_documentation": "https://cloud.google.com/functions/docs", | ||
| "release_level": "stable", | ||
| "repo": "googleapis/google-cloud-node" | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
The metadata file has been reformatted with 4-space indentation, which is inconsistent with the 2-space indentation standard used across other .repo-metadata.json files in this repository. Additionally, the codeowner_team and requires_billing fields were removed. Removing codeowner_team can break automated PR routing and issue assignment. Please restore these fields and revert to 2-space indentation.
Suggested change
| { | |
| "issue_tracker": "", | |
| "distribution_name": "@google-cloud/functions", | |
| "product_documentation": "https://cloud.google.com/functions", | |
| "api_id": "cloudfunctions.googleapis.com", | |
| "client_documentation": "https://cloud.google.com/nodejs/docs/reference/functions/latest", | |
| "repo": "googleapis/google-cloud-node", | |
| "release_level": "stable", | |
| "requires_billing": false, | |
| "name_pretty": "Google Cloud Functions", | |
| "name": "nodejs-functions", | |
| "codeowner_team": "@googleapis/aap-dpes", | |
| "default_version": "v1", | |
| "language": "nodejs", | |
| "api_shortname": "cloudfunctions", | |
| "library_type": "GAPIC_AUTO" | |
| } | |
| "api_description": "Manages lightweight user-provided functions executed in response to events.", | |
| "api_id": "cloudfunctions.googleapis.com", | |
| "api_shortname": "cloudfunctions", | |
| "client_documentation": "https://cloud.google.com/nodejs/docs/reference/functions/latest", | |
| "default_version": "v1", | |
| "distribution_name": "@google-cloud/functions", | |
| "issue_tracker": "https://issuetracker.google.com/savedsearches/559729", | |
| "language": "nodejs", | |
| "library_type": "GAPIC_AUTO", | |
| "name": "cloudfunctions", | |
| "name_pretty": "Cloud Functions", | |
| "product_documentation": "https://cloud.google.com/functions/docs", | |
| "release_level": "stable", | |
| "repo": "googleapis/google-cloud-node" | |
| } | |
| { | |
| "api_description": "Manages lightweight user-provided functions executed in response to events.", | |
| "api_id": "cloudfunctions.googleapis.com", | |
| "api_shortname": "cloudfunctions", | |
| "client_documentation": "https://cloud.google.com/nodejs/docs/reference/functions/latest", | |
| "default_version": "v1", | |
| "distribution_name": "@google-cloud/functions", | |
| "issue_tracker": "https://issuetracker.google.com/savedsearches/559729", | |
| "language": "nodejs", | |
| "library_type": "GAPIC_AUTO", | |
| "name": "cloudfunctions", | |
| "name_pretty": "Cloud Functions", | |
| "product_documentation": "https://cloud.google.com/functions/docs", | |
| "release_level": "stable", | |
| "repo": "googleapis/google-cloud-node", | |
| "requires_billing": false, | |
| "codeowner_team": "@googleapis/aap-dpes" | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For librarian/6500