chore: onboard google-cloud-dialogflow-cx to librarian#8754
Conversation
quirogas
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Dialogflow CX Node.js client library by enabling code generation, updating repository metadata, deprecating MP3 audio encoding in proto definitions, and adding long-running operations support along with corresponding tests across several v3beta1 clients. A critical issue was identified in the repository metadata changes, where renaming the package to "dialogflow" and "Dialogflow" would cause conflicts with the Dialogflow ES package, and a suggestion was provided to revert these names.
| "name": "dialogflow", | ||
| "name_pretty": "Dialogflow", |
There was a problem hiding this comment.
Changing "name" to "dialogflow" and "name_pretty" to "Dialogflow" will cause conflicts with the @google-cloud/dialogflow package (which represents Dialogflow ES). For Dialogflow CX, these fields should remain "dialogflow-cx" and "Dialogflow CX API" to ensure correct documentation routing and display.
| "name": "dialogflow", | |
| "name_pretty": "Dialogflow", | |
| "name": "dialogflow-cx", | |
| "name_pretty": "Dialogflow CX API", |
There was a problem hiding this comment.
This is a concern, looking into this.
1 participant
For #librarian/6402
For #librarian/6499