refactor(storage): make onResponse async and improve retry error handling#8753
Open
thiyaguk09 wants to merge 7 commits into
Open
refactor(storage): make onResponse async and improve retry error handling#8753thiyaguk09 wants to merge 7 commits into
thiyaguk09 wants to merge 7 commits into
Conversation
… for retry failures
- Unify formatting of Errors and objects under a single block inside formatRetryError to reduce code duplication. - Ensure standard errors, GaxiosErrors, and custom errors with empty/missing properties are correctly formatted.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a helper function buildRetryError to format detailed error messages when retries are exceeded, and updates the retry logic and tests accordingly. However, the changes also make onResponse and attemptDelayedRetry asynchronous. The reviewer correctly points out that these functions do not perform any asynchronous operations, making the async and await keywords unnecessary. Feedback is provided to revert these functions and their associated tests back to their synchronous implementations to avoid unnecessary overhead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #7346