fix(storage): destroy local read stream on upload write failure to prevent resource leaks#8752
Open
thiyaguk09 wants to merge 6 commits into
Open
fix(storage): destroy local read stream on upload write failure to prevent resource leaks#8752thiyaguk09 wants to merge 6 commits into
thiyaguk09 wants to merge 6 commits into
Conversation
…event resource leaks
…ream override in tests
Contributor
There was a problem hiding this comment.
Code Review
This pull request ensures that the local readStream is properly destroyed if errors occur during the upload or piping process, and adds a corresponding unit test to verify this behavior. The review feedback highlights a potential resource leak if createWriteStream or progress listener attachment throws an error synchronously before the readStream is piped, and suggests instantiating the readStream after the writable stream is set up.
…estruction in upload flow
Dhriti07
reviewed
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #7325