Skip to content

fix(storage): resolve transport and retry issues#8235

Open
thiyaguk09 wants to merge 4 commits intogoogleapis:storage-node-18from
thiyaguk09:storage-transport-retry-fix
Open

fix(storage): resolve transport and retry issues#8235
thiyaguk09 wants to merge 4 commits intogoogleapis:storage-node-18from
thiyaguk09:storage-transport-retry-fix

Conversation

@thiyaguk09
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@thiyaguk09 thiyaguk09 requested review from a team as code owners May 7, 2026 12:00
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label May 7, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors request handling and retry logic by transitioning from the common Service class to a specialized StorageTransport. Key changes include the introduction of granular idempotency logic for HTTP methods, improved encryption header management, and a custom parameter serializer. Review feedback identifies a high-severity race condition involving shared interceptors on the Gaxios instance and inconsistent return types in the response handler. Additionally, improvements were suggested regarding the efficiency of JSON parsing within retry loops and the safety of non-null assertions in encryption headers.

Comment thread handwritten/storage/src/storage-transport.ts
Comment thread handwritten/storage/src/storage-transport.ts
Comment thread handwritten/storage/src/storage.ts
Comment thread handwritten/storage/src/file.ts Outdated
thiyaguk09 and others added 2 commits May 7, 2026 17:49
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant