Skip to content

feat(storage): respect com.google.cloud.storage.Hasher.read system property in JSON read paths #13526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nidhiii-27 wants to merge 1 commit into
base: disable-bidi-checksum-new
Choose a base branch
from
+3 −4
Draft

feat(storage): respect com.google.cloud.storage.Hasher.read system property in JSON read paths #13526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ogle-cloud-storage/src/main/java/com/google/cloud/storage/HttpDownloadSessionBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public static final class ReadableByteChannelSessionBuilder {

private ReadableByteChannelSessionBuilder(BlobReadChannelContext blobReadChannelContext) {
this.blobReadChannelContext = blobReadChannelContext;
this.hasher = Hasher.defaultHasher();
this.hasher = Hasher.readHasher();
this.autoGzipDecompression = false;
}

Expand Down
2 changes: 1 addition & 1 deletion ...ogle-cloud-storage/src/main/java/com/google/cloud/storage/HttpStorageRpcHasherHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public final class HttpStorageRpcHasherHelper {
private final Hasher hasher;

private HttpStorageRpcHasherHelper() {
hasher = Hasher.defaultHasher();
hasher = Hasher.readHasher();
}

/**
Expand Down
3 changes: 1 addition & 2 deletions ...ge/google-cloud-storage/src/main/java/com/google/cloud/storage/ReadAsSeekableChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@
public final class ReadAsSeekableChannel extends ReadProjectionConfig<SeekableByteChannel> {

static final ReadAsSeekableChannel INSTANCE =
new ReadAsSeekableChannel(
Hasher.readHasher(), LinearExponentialRangeSpecFunction.INSTANCE);
new ReadAsSeekableChannel(Hasher.readHasher(), LinearExponentialRangeSpecFunction.INSTANCE);

private final Hasher hasher;
private final RangeSpecFunction rangeSpecFunction;
Expand Down
Loading