Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request configures the java-showcase module to skip Maven deployment and includes it in the hermetic build utility's library list. The feedback suggests also setting the skipNexusStagingDeployMojo property to true to ensure the deployment process is fully bypassed when using the Nexus staging plugin.
| <checkstyle.skip>true</checkstyle.skip> | ||
| <clirr.skip>true</clirr.skip> | ||
| <enforcer.skip>true</enforcer.skip> | ||
| <maven.deploy.skip>true</maven.deploy.skip> |
There was a problem hiding this comment.
In addition to maven.deploy.skip, it is often necessary to set skipNexusStagingDeployMojo to true when using the nexus-staging-maven-plugin (common in Google Cloud Java projects) to fully skip the deployment process. This ensures that the staging process is also bypassed.
<maven.deploy.skip>true</maven.deploy.skip>
<skipNexusStagingDeployMojo>true</skipNexusStagingDeployMojo>
References
- In Maven aggregator POMs that are not parent POMs, it is acceptable to use skip tags to disable plugin configurations for the aggregator itself.
|
|
1 participant
We added java-showcase to the top-level folders and automation ensures it is part of the reactor. This setting ensures that we don't try to deploy the java-showcase packages.