fix(bqjdbc): Log exception messages - part 3#12920
Conversation
There was a problem hiding this comment.
Code Review
This pull request standardizes exception handling and logging across the BigQuery JDBC driver by ensuring that exceptions are logged at the severe level before being thrown. It introduces loggers to several utility classes and refactors catch blocks to provide more descriptive error messages. Review feedback suggests restoring lost context, specifically the 'catalogParam' variable, in BigQueryDatabaseMetaData and recommends using a static final logger in PooledConnectionDataSource to align with standard practices.
…gle/cloud/bigquery/jdbc/BigQueryDatabaseMetaData.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…gle/cloud/bigquery/jdbc/BigQueryDatabaseMetaData.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…gle/cloud/bigquery/jdbc/PooledConnectionDataSource.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| throw new BigQueryJdbcException(ex); | ||
| BigQueryJdbcException e = | ||
| new BigQueryJdbcException("IOException during ArrowDeserializer creation", ex); | ||
| LOG.severe(e, e.getMessage()); |
There was a problem hiding this comment.
When we get Mdc working, can this LOG be a part of the exception? At least for exceptions that we own they could log sever errors, so we'll never forget to log it.
b/505826451