Skip to content

ci: apply gRPC SSL workaround to reduce flakes in demo builds - #16552

Draft
scotthart wants to merge 4 commits into
googleapis:mainfrom
scotthart:ci_demo_grpc_ssl
Draft

scotthart wants to merge 4 commits into
googleapis:mainfrom
scotthart:ci_demo_grpc_ssl

Conversation

@scotthart

Copy link
Copy Markdown
Member

No description provided.

@scotthart
scotthart requested a review from a team as a code owner October 8, 2026 14:52

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gRPC version from v1.71.2 to v1.84.0 across several demo Dockerfiles and the packaging documentation, while switching the SSL provider configuration from package to module and adding manual downloads for grpc-proto and BoringSSL. The feedback advises against propagating these BoringSSL module workarounds to the public packaging documentation (doc/packaging.md), as standard Linux distribution packaging guidelines require linking against the system-provided OpenSSL package to ensure automatic security updates.

Comment thread doc/packaging.md
@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.39%. Comparing base (bb0deb0) to head (dd5e77d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16552      +/-   ##
==========================================
- Coverage   92.40%   92.39%   -0.02%     
==========================================
  Files        2262     2262              
  Lines      218381   218381              
==========================================
- Hits       201801   201777      -24     
- Misses      16580    16604      +24     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart
scotthart marked this pull request as draft October 8, 2026 15:30

This branch was successfully deployed

1 active deployment
false — dd5e77d2 Deployed Oct 8, 2026 by scotthart via Save PR ref #12346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant