Skip to content

mTLS support for batch and custom http object - #2442

Open
jay0lee wants to merge 3 commits into
googleapis:mainfrom
jay0lee:main
Open

jay0lee wants to merge 3 commits into
googleapis:mainfrom
jay0lee:main

Conversation

@jay0lee

@jay0lee jay0lee commented Jul 17, 2024

Copy link
Copy Markdown
Contributor

First stab at addressing #2440.

  • mTLS logic in build_from_document such as choosing the mtlsRootUrl should be executed even if we pass a custom http object in.
  • add an is_mtls bool attribute to Resource so we can make quick decisions about the state of mTLS later.
  • ensure our batch URI is using the mTLS host when is_mtls == True

feedback welcome.

@jay0lee
jay0lee requested a review from a team July 17, 2024 11:53
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Jul 17, 2024

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants