Skip to content

fix(gapic-generator): Indent note in the Config#credentials attribute properly #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dazuma wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(gapic-generator): Indent note in the Config#credentials attribute properly #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8d1267
fix(gapic-generator): Indent note in the Config#credentials attribute…
dazuma Jul 21, 2026
16a38c2
chore: Update goldens after note indentation fix
dazuma Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions gapic-generator/templates/default/service/client/_config.text.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,11 @@
# end
#
# @note Warning: If you accept a credential configuration (JSON file or Hash) from an
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# @return [::Object]
# @!attribute [rw] scope
# The OAuth scopes
Expand Down Expand Up @@ -185,7 +185,7 @@ class Configuration
# * `:jitter` (*type:* `Numeric`) - The jitter in seconds. Default: 1.0.
# * `:retry_codes` (*type:* `Array<String>`) - The error codes that should
# trigger a retry.
#
#
class Rpcs
<%- method_service.methods.each do |method| -%>
##
Expand Down
10 changes: 5 additions & 5 deletions ...ed/output/ads/googleads/lib/google/ads/google_ads/v19/services/campaign_service/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,11 +478,11 @@ def enable_p_max_brand_guidelines request, options = nil
# end
#
# @note Warning: If you accept a credential configuration (JSON file or Hash) from an
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# @return [::Object]
# @!attribute [rw] scope
# The OAuth scopes
Expand Down
10 changes: 5 additions & 5 deletions shared/output/cloud/grafeas_v1/lib/grafeas/v1/grafeas/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1512,11 +1512,11 @@ def list_note_occurrences request, options = nil
# end
#
# @note Warning: If you accept a credential configuration (JSON file or Hash) from an
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# @return [::Object]
# @!attribute [rw] scope
# The OAuth scopes
Expand Down
10 changes: 5 additions & 5 deletions shared/output/cloud/language_v1/lib/google/cloud/language/v1/language_service/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1307,11 +1307,11 @@ def annotate_text request, options = nil
# end
#
# @note Warning: If you accept a credential configuration (JSON file or Hash) from an
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# @return [::Object]
# @!attribute [rw] scope
# The OAuth scopes
Expand Down
10 changes: 5 additions & 5 deletions ...utput/cloud/language_v1beta1/lib/google/cloud/language/v1beta1/language_service/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,11 +569,11 @@ def annotate_text request, options = nil
# end
#
# @note Warning: If you accept a credential configuration (JSON file or Hash) from an
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# @return [::Object]
# @!attribute [rw] scope
# The OAuth scopes
Expand Down
10 changes: 5 additions & 5 deletions ...utput/cloud/language_v1beta2/lib/google/cloud/language/v1beta2/language_service/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,11 +808,11 @@ def annotate_text request, options = nil
# end
#
# @note Warning: If you accept a credential configuration (JSON file or Hash) from an
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# @return [::Object]
# @!attribute [rw] scope
# The OAuth scopes
Expand Down
10 changes: 5 additions & 5 deletions shared/output/cloud/location/lib/google/cloud/location/locations/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,11 +427,11 @@ def get_location request, options = nil
# end
#
# @note Warning: If you accept a credential configuration (JSON file or Hash) from an
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# @return [::Object]
# @!attribute [rw] scope
# The OAuth scopes
Expand Down
10 changes: 5 additions & 5 deletions ...tmanager_v1beta1/lib/google/cloud/secret_manager/v1beta1/secret_manager_service/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1652,11 +1652,11 @@ def test_iam_permissions request, options = nil
# end
#
# @note Warning: If you accept a credential configuration (JSON file or Hash) from an
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# @return [::Object]
# @!attribute [rw] scope
# The OAuth scopes
Expand Down
10 changes: 5 additions & 5 deletions shared/output/cloud/speech_v1/lib/google/cloud/speech/v1/adaptation/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1249,11 +1249,11 @@ def delete_custom_class request, options = nil
# end
#
# @note Warning: If you accept a credential configuration (JSON file or Hash) from an
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# @return [::Object]
# @!attribute [rw] scope
# The OAuth scopes
Expand Down
10 changes: 5 additions & 5 deletions shared/output/cloud/speech_v1/lib/google/cloud/speech/v1/speech/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,11 +516,11 @@ def streaming_recognize request, options = nil
# end
#
# @note Warning: If you accept a credential configuration (JSON file or Hash) from an
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# @return [::Object]
# @!attribute [rw] scope
# The OAuth scopes
Expand Down
10 changes: 5 additions & 5 deletions shared/output/cloud/speech_v1/lib/google/cloud/speech/v1/speech/operations.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,11 +670,11 @@ def wait_operation request, options = nil
# end
#
# @note Warning: If you accept a credential configuration (JSON file or Hash) from an
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# @return [::Object]
# @!attribute [rw] scope
# The OAuth scopes
Expand Down
10 changes: 5 additions & 5 deletions shared/output/cloud/vision_v1/lib/google/cloud/vision/v1/image_annotator/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,11 +706,11 @@ def async_batch_annotate_files request, options = nil
# end
#
# @note Warning: If you accept a credential configuration (JSON file or Hash) from an
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# @return [::Object]
# @!attribute [rw] scope
# The OAuth scopes
Expand Down
10 changes: 5 additions & 5 deletions shared/output/cloud/vision_v1/lib/google/cloud/vision/v1/image_annotator/operations.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,11 +670,11 @@ def wait_operation request, options = nil
# end
#
# @note Warning: If you accept a credential configuration (JSON file or Hash) from an
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# @return [::Object]
# @!attribute [rw] scope
# The OAuth scopes
Expand Down
10 changes: 5 additions & 5 deletions shared/output/cloud/vision_v1/lib/google/cloud/vision/v1/product_search/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2211,11 +2211,11 @@ def purge_products request, options = nil
# end
#
# @note Warning: If you accept a credential configuration (JSON file or Hash) from an
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# @return [::Object]
# @!attribute [rw] scope
# The OAuth scopes
Expand Down
10 changes: 5 additions & 5 deletions shared/output/cloud/vision_v1/lib/google/cloud/vision/v1/product_search/operations.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,11 +670,11 @@ def wait_operation request, options = nil
# end
#
# @note Warning: If you accept a credential configuration (JSON file or Hash) from an
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# external source for authentication to Google Cloud, you must validate it before
# providing it to a Google API client library. Providing an unvalidated credential
# configuration to Google APIs can compromise the security of your systems and data.
# For more information, refer to [Validate credential configurations from external
# sources](https://cloud.google.com/docs/authentication/external/externally-sourced-credentials).
# @return [::Object]
# @!attribute [rw] scope
# The OAuth scopes
Expand Down
Loading
Loading