Skip to content

fix(sample): add missing continue in IP info loop for non-GOOGLE_ADS accounts #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jradcliff merged 1 commit into from
Jun 25, 2026
Merged

fix(sample): add missing continue in IP info loop for non-GOOGLE_ADS accounts #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions samples/audiences/ingest_audience_members.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ async function main() {
`Skipping IP address information for operating account type ${operatingAccountType}. ` +
'Sending IP address is only supported for operating account type GOOGLE_ADS.',
);
continue;
}

const ipAddress = (ipInfo.ipAddress || '').trim();
Expand Down