Skip to content

[derive] Document MSRV as 1.56, update MSRV policy - #3500

Open
joshlf wants to merge 1 commit into
mainfrom
Glcxdw676wu3lpncyoxezb43sqrukyhpa
Open

[derive] Document MSRV as 1.56, update MSRV policy#3500
joshlf wants to merge 1 commit into
mainfrom
Glcxdw676wu3lpncyoxezb43sqrukyhpa

Conversation

@joshlf

@joshlf joshlf commented Jul 28, 2026

Copy link
Copy Markdown
Member

Update our MSRV policy to promise that zerocopy-derive will always
support its MSRV, but that getting this MSRV to work in practice may
require pinning dependencies (in particular, syn) which have more lax
MSRV policies.


Latest Update: v2 — Compare vs v1

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v1 Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Glcxdw676wu3lpncyoxezb43sqrukyhpa && git checkout -b pr-Glcxdw676wu3lpncyoxezb43sqrukyhpa FETCH_HEAD

Checkout

git fetch origin refs/heads/Glcxdw676wu3lpncyoxezb43sqrukyhpa && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Glcxdw676wu3lpncyoxezb43sqrukyhpa && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Glcxdw676wu3lpncyoxezb43sqrukyhpa

Stacked PRs enabled by GHerrit.

@joshlf
joshlf requested a review from jswrenn July 28, 2026 16:50
@joshlf
joshlf enabled auto-merge July 28, 2026 16:51
@codecov-commenter

codecov-commenter commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (53a3fbf) to head (0aa56d3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3500   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          20       20           
  Lines        6093     6093           
=======================================
  Hits         5597     5597           
  Misses        496      496           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf

joshlf commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

@jswrenn Note, quoting #3495 (comment):

I've opened #3500, which does the same as #3498 but also documents a new MSRV policy: That we will always support some set of package resolutions which satisfy the current 1.56 MSRV. Note that despite this policy, the plan is still to have a different, more relaxed MSRV policy when we release zerocopy 0.9.

@jswrenn How do you feel about this proposed policy? Merging #3500 will have the effect of closing us off from upgrading our syn dep to 3.0, which will affect our ability to support unsafe fields.

Update our MSRV policy to promise that `zerocopy-derive` will always
support its MSRV, but that getting this MSRV to work in practice may
require pinning dependencies (in particular, `syn`) which have more lax
MSRV policies.

gherrit-pr-id: Glcxdw676wu3lpncyoxezb43sqrukyhpa
@joshlf
joshlf force-pushed the Glcxdw676wu3lpncyoxezb43sqrukyhpa branch from 21b8534 to 0aa56d3 Compare July 28, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants