Skip to content

Remove duplicated example in IntoBytes::write_to_suffix#3422

Open
ojeda wants to merge 1 commit into
google:mainfrom
ojeda:duplicated-example
Open

Remove duplicated example in IntoBytes::write_to_suffix#3422
ojeda wants to merge 1 commit into
google:mainfrom
ojeda:duplicated-example

Conversation

@ojeda
Copy link
Copy Markdown

@ojeda ojeda commented May 31, 2026

Commit b964747 ("Improve AsBytes documentation (#660)") added examples but one of those (IntoBytes::write_to_suffix) has duplicated lines, i.e. the Err case is explained below.

Thus remove them.

Commit b964747 ("Improve `AsBytes` documentation (google#660)") added
examples but one of those (`IntoBytes::write_to_suffix`) has duplicated
lines, i.e. the `Err` case is explained below.

Thus remove them.

Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 31, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (f70e422) to head (5e03e66).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3422      +/-   ##
==========================================
- Coverage   91.85%   91.85%   -0.01%     
==========================================
  Files          20       20              
  Lines        6093     6089       -4     
==========================================
- Hits         5597     5593       -4     
  Misses        496      496              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jswrenn jswrenn enabled auto-merge May 31, 2026 17:05
@joshlf
Copy link
Copy Markdown
Member

joshlf commented May 31, 2026

Once #3423 merges, we can re-run CI tests here and they should pass.

@joshlf
Copy link
Copy Markdown
Member

joshlf commented May 31, 2026

Oh also, @ojeda you'll need to sign the CLA – alternatively we can just re-upload this for you, which also works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants