Limit StackTraceCleaner cause traversal to prevent infinite loops - #1691
Open
arimu1 wants to merge 1 commit into
Open
Limit StackTraceCleaner cause traversal to prevent infinite loops#1691arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
StackTraceCleaner already guarded against cyclic cause references with a visited set, but broken getCause() implementations that return a new Throwable on each call could still hang. Cap related-throwable traversal at 1000 and add a regression test. Fixes google#747
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StackTraceCleanerrelated-throwable traversal at 1000 to prevent hangs whengetCause()returns a new instance on each call (in addition to the existing identity-hash visited set for cyclic references).infiniteCauseChainsAreHandledregression test mirroring the existingcyclesAreHandledtest style.Fixes #747
Test plan
mvn -pl core -Dtest=StackTraceCleanerTest test(22 tests, 0 failures)Made with Cursor