Avoid testing identity equality on Boolean instances. - #1690
Merged
Conversation
[JEP 401](https://openjdk.org/jeps/401) is making such comparisons equivalent to value-based equality. That doesn't actually affect the usages here, which compare value types to non-value types. So we could keep those tests as they are if we want; we'd just likely eventually receive some robocomments that want us to migrate them to `isEqualTo`. RELNOTES=n/a PiperOrigin-RevId: 962399630
copybara-service
Bot
force-pushed
the
test_962375395
branch
from
August 10, 2026 22:24
379f1a4 to
2b95613
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid testing identity equality on
Booleaninstances.JEP 401 is making such comparisons equivalent to value-based equality.
That doesn't actually affect the usages here, which compare value types to non-value types. So we could keep those tests as they are if we want; we'd just likely eventually receive some robocomments that want us to migrate them to
isEqualTo.RELNOTES=n/a