Add Jedis (for Valkey) caches for domains and hosts#3013
Open
gbrodman wants to merge 1 commit intogoogle:masterfrom
Open
Add Jedis (for Valkey) caches for domains and hosts#3013gbrodman wants to merge 1 commit intogoogle:masterfrom
gbrodman wants to merge 1 commit intogoogle:masterfrom
Conversation
gbrodman
force-pushed
the
jedis
branch
5 times, most recently
from
ffce812 to
2198f73
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public static DomainCache provideDomainCache(Optional<UnifiedJedis> jedis, Clock clock) { | ||
| if (jedis.isEmpty()) { | ||
| return domainName -> | ||
| ForeignKeyUtils.loadResourceByCache(Domain.class, domainName, clock.nowUtc()); |
We add optional Valkey caching of hosts and domains for future use. Eventually, this will allow us to pre-warm large amounts of data in Valkey for quick retrieval during actions like RDAP. Note: this doesn't actually use the caches yet. We use Jedis instead of Redisson for speed purposes (https://www.instaclustr.com/blog/redis-java-clients-and-client-side-caching/) which means that we have to implement our own multilayer cache but that's not the worst thing in the world.
| public static TimeOfYear fromDateTime(DateTime dateTime) { | ||
| DateTime nextYear = dateTime.plusYears(1); // This turns February 29 into February 28. | ||
| DateTime nextYear = | ||
| DateTimeUtils.leapSafeAddYears(dateTime, 1); // This turns February 29 into February 28. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add optional Valkey caching of hosts and domains for future use. Eventually, this will allow us to pre-warm large amounts of data in Valkey for quick retrieval during actions like RDAP.
Note: this doesn't actually use the caches yet.
We use Jedis instead of Redisson for speed purposes (https://www.instaclustr.com/blog/redis-java-clients-and-client-side-caching/) which means that we have to implement our own multilayer cache but that's not the worst thing in the world.
This change is