Fix memory leaks in repeated field and enum list handling.#2790
Open
copybara-service[bot] wants to merge 1 commit into
Open
Fix memory leaks in repeated field and enum list handling.#2790copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Add AUTORELEASE to the result of CGPNewRepeatedEnumValueFieldList and RELEASE_ to the list parameter in CGPRepeatedFieldListToNSArray to prevent memory leaks. The CGPNewRepeatedFieldList allocates the list without the autorelease, returning a retained object. Here the CGPNewRepeatedEnumValueFieldList returns a retained object and the caller is responsible for releasing. PiperOrigin-RevId: 937893270
copybara-service
Bot
force-pushed
the
test_937893270
branch
from
2a4280d to
a342fb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix memory leaks in repeated field and enum list handling.
Add AUTORELEASE to the result of CGPNewRepeatedEnumValueFieldList and RELEASE_ to the list parameter in CGPRepeatedFieldListToNSArray to prevent memory leaks.
The CGPNewRepeatedFieldList allocates the list without the autorelease, returning a retained object. Here the CGPNewRepeatedEnumValueFieldList returns a retained object and the caller is responsible for releasing.