Rewrite integer and long compound assignments to match Java overflow behavior.#2784
Open
copybara-service[bot] wants to merge 1 commit into
Open
Rewrite integer and long compound assignments to match Java overflow behavior.#2784copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…behavior. Adds inline functions in J2ObjC_source.h for `+=`, `*=`, and `-=` operations on byte, char, short, int and long types. These functions use unsigned arithmetic for the operations to ensure Java's two's complement overflow behavior is preserved, then cast the result back to the signed type. The OperatorRewriter is updated to rewrite compound assignmentsto use these new inline functions. This ensures that expressions like `i += j` or `l *= k` in Java are translated to Objective-C with the correct overflow semantics. PiperOrigin-RevId: 936897994
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite integer and long compound assignments to match Java overflow behavior.
Adds inline functions in J2ObjC_source.h for
+=,*=, and-=operations on byte, char, short, int and long types. These functions use unsigned arithmetic for the operations to ensure Java's two's complement overflow behavior is preserved, then cast the result back to the signed type.The OperatorRewriter is updated to rewrite compound assignmentsto use these new inline functions. This ensures that expressions like
i += jorl *= kin Java are translated to Objective-C with the correct overflow semantics.