Emulate Java integer overflow behavior in Objective-C.#2782
Open
copybara-service[bot] wants to merge 1 commit into
Open
Emulate Java integer overflow behavior in Objective-C.#2782copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
This change introduces helper functions (JreIntAdd, JreIntSub, JreIntMul, etc.) that use unsigned arithmetic to ensure that integer and long addition, subtraction, and multiplication operations in j2objc-translated code wrap around on overflow, matching Java's specification. The translator's OperatorRewriter is updated to use these new helper functions for the +, -, and * operators on int and long types. New tests are added to IntegerTest to verify the overflow wraparound. PiperOrigin-RevId: 936861259
copybara-service
Bot
force-pushed
the
test_936861259
branch
from
9694407 to
a57f4f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emulate Java integer overflow behavior in Objective-C.
This change introduces helper functions (JreIntAdd, JreIntSub, JreIntMul, etc.) that use unsigned arithmetic to ensure that integer and long addition, subtraction, and multiplication operations in j2objc-translated code wrap around on overflow, matching Java's specification. The translator's OperatorRewriter is updated to use these new helper functions for the +, -, and * operators on int and long types. New tests are added to IntegerTest to verify the overflow wraparound.