Reimplement support for abstract types with @ObjectiveCKmpMethod in J2ObjC#2738
Merged
copybara-service[bot] merged 1 commit intomasterfrom May 8, 2026
Merged
Reimplement support for abstract types with @ObjectiveCKmpMethod in J2ObjC#2738copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
d1acfb0 to
1357a22
Compare
47fb075 to
58e9ba7
Compare
…2ObjC - Introduced MappingStrategy to handle concrete and abstract methods differently. - Refactored AdapterContext to use the strategy. - Updated AdapterGenerator to detect abstract methods and overrides. - Skipped package-info types in endVisit to avoid errors in override check. - Updated unit tests to expect adapters in concrete subclasses and handled generics in assertions. PiperOrigin-RevId: 912708575
58e9ba7 to
537ab12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplement support for abstract types with @ObjectiveCKmpMethod in J2ObjC