nvproxy: fix integer overflow in ctrlClientSystemGetP2PCapsInitializeArray#13709
Open
destro4evr-rgb wants to merge 1 commit into
Open
nvproxy: fix integer overflow in ctrlClientSystemGetP2PCapsInitializeArray#13709destro4evr-rgb wants to merge 1 commit into
destro4evr-rgb wants to merge 1 commit into
Conversation
…Array numEntries*4 can overflow uint64 when gpuCount is large (e.g. 2^31), causing the size guard to pass and make([]uint32, numEntries) to be called with a length that overflows the runtime's internal size check. The resulting panic in makeslice is unrecovered and terminates the sentry, killing all containers in the sandbox. Fix by dividing the constant before comparing instead of multiplying numEntries, which avoids the secondary overflow entirely. Fixes google#13689
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13689
ctrlClientSystemGetP2PCapsInitializeArraywidens thegpuCountmultiplication touint64to avoid a first overflow, but the size guard:performs a second multiplication (
numEntries*4) that can itself overflowuint64. WhengpuCount = 2^31,numEntries = 2^62andnumEntries*4wraps to 0, so the guard passes andmake([]uint32, 2^62)is called. Go'smakeslicedetects the internal size overflow and panics. There is norecover()in the sentry's execution path, so the sentry process terminatesand all containers in the sandbox are killed.
Fix: divide the constant by 4 before comparing, which involves no multiplication and cannot overflow.