Skip to content

Add "delete site" option - #2579

Open
rfontanarosa wants to merge 18 commits into
masterfrom
rfontanarosa/2565/edit-delete-sites
Open

Add "delete site" option #2579
rfontanarosa wants to merge 18 commits into
masterfrom
rfontanarosa/2565/edit-delete-sites

Conversation

@rfontanarosa

@rfontanarosa rfontanarosa commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

closes #2565

Registrazione.schermo.2026-07-30.alle.15.07.45.mov

@rfontanarosa rfontanarosa self-assigned this Jul 30, 2026
@rfontanarosa rfontanarosa changed the title Rfontanarosa/2565/edit delete sites Add "delete location" option Jul 30, 2026
@codecov-commenter

codecov-commenter commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.45%. Comparing base (b2b3586) to head (8b43641).

Files with missing lines Patch % Lines
web/src/app/converters/loi-data-converter.ts 0.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2579      +/-   ##
==========================================
+ Coverage   62.13%   62.45%   +0.32%     
==========================================
  Files         121      121              
  Lines        2947     2975      +28     
  Branches      441      449       +8     
==========================================
+ Hits         1831     1858      +27     
  Misses       1053     1053              
- Partials       63       64       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rfontanarosa
rfontanarosa requested a review from gino-m July 30, 2026 13:10
@rfontanarosa
rfontanarosa marked this pull request as ready for review July 30, 2026 13:10
@gino-m gino-m changed the title Add "delete location" option Add "delete site" option Jul 31, 2026

@gino-m gino-m left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also call out that the data will be removed in the menu option, eg:

"Delete site and associated data"

@rfontanarosa

Copy link
Copy Markdown
Collaborator Author

We should also call out that the data will be removed in the menu option, eg:

"Delete site and associated data"

isn't the menu label too long? everything is described in the confirmation dialog and an additional option "Delete submissions" will be added in the near future (see image).

another possibility is to have "Delete site and data" or "Delete site and submissions", but they are super long as well.

wdyt? @gino-m @jo-spek @vittorino

Screenshot 2026-08-01 alle 11 01 35

@gino-m

gino-m commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Then I would go with "Delete site"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Edit] Delete sites

3 participants