fix: show add LOI button when zoomed out - #3858
Open
arpitagarwal1301 wants to merge 1 commit into
Open
Conversation
arpitagarwal1301
temporarily deployed
to
e2e-approval
July 25, 2026 20:01 — with
GitHub Actions
Inactive
andreia-ferreira
approved these changes
Jul 27, 2026
Comment on lines
+180
to
181
| if (survey == null) listOf() | ||
| else survey.jobs.filter { it.canDataCollectorsAddLois && it.getAddLoiTask() != null } |
Collaborator
There was a problem hiding this comment.
optional: can be slightly simplified with
Suggested change
| if (survey == null) listOf() | |
| else survey.jobs.filter { it.canDataCollectorsAddLois && it.getAddLoiTask() != null } | |
| survey?.jobs?.filter { it.canDataCollectorsAddLois && it.getAddLoiTask() != null } ?: listOf() |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3858 +/- ##
============================================
+ Coverage 67.37% 67.46% +0.09%
- Complexity 1838 1842 +4
============================================
Files 407 407
Lines 10755 10755
Branches 1418 1415 -3
============================================
+ Hits 7246 7256 +10
+ Misses 2763 2762 -1
+ Partials 746 737 -9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3553
Verification
./gradlew checkCode./gradlew :app:ktfmtCheck :app:testLocalDebugUnitTest --tests 'org.groundplatform.android.ui.home.mapcontainer.HomeScreenMapContainerViewModelTest'git diff --checkLimitations