Skip to content

test: Cover CodeResult JSON marshaling#4257

Closed
Haihan-Jiang wants to merge 1 commit into
google:masterfrom
Haihan-Jiang:test-code-result-marshal
Closed

test: Cover CodeResult JSON marshaling#4257
Haihan-Jiang wants to merge 1 commit into
google:masterfrom
Haihan-Jiang:test-code-result-marshal

Conversation

@Haihan-Jiang
Copy link
Copy Markdown

Adds standalone JSON marshal coverage for CodeResult.

CodeSearchResult already had marshal coverage for the outer response shape. This adds direct coverage for the exported result type and its nested repository/text match fields.

Tests:

  • gofmt -w github/search_test.go
  • go test ./github -run 'TestCode(Result|SearchResult)_Marshal'
  • go test ./github
  • git diff --check

Refs #55.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label May 26, 2026
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Haihan-Jiang!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra - @munlicode

Copy link
Copy Markdown
Contributor

@munlicode munlicode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented May 27, 2026

Thank you for your understanding, @Haihan-Jiang.
Closing as no longer needed. See #55.

@gmlewis gmlewis closed this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants