Skip to content

chore: Switch legacy redirect handling to new pattern#4161

Merged
gmlewis merged 1 commit intogoogle:masterfrom
stevehipwell:fix-redirect-handling
Apr 17, 2026
Merged

chore: Switch legacy redirect handling to new pattern#4161
gmlewis merged 1 commit intogoogle:masterfrom
stevehipwell:fix-redirect-handling

Conversation

@stevehipwell
Copy link
Copy Markdown
Contributor

This PR switches the legacy redirect pattern that modifies the global client to use the new pattern introduced in #3411.

Related to #3915

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.85%. Comparing base (cd716ed) to head (9016f4e).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
github/migrations.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4161      +/-   ##
==========================================
+ Coverage   93.83%   93.85%   +0.01%     
==========================================
  Files         209      209              
  Lines       19685    19667      -18     
==========================================
- Hits        18472    18458      -14     
+ Misses       1015     1013       -2     
+ Partials      198      196       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 16, 2026
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stevehipwell!
Do we have any integration tests associated with these endpoints so that they can be validated that they functionally still work? If not, do you think this would be a good use of integration tests?
Otherwise, LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @alexandear - @zyfy29 - @Not-Dhananjay-Mishra - @munlicode

@stevehipwell
Copy link
Copy Markdown
Contributor Author

@gmlewis TestRepositories_DownloadReleaseAsset covers DownloadReleaseAsset. I don't think migration would be something to include in the integration tests due to permissions.

Comment thread github/migrations.go
Copy link
Copy Markdown
Contributor

@Not-Dhananjay-Mishra Not-Dhananjay-Mishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Apr 17, 2026
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stevehipwell and @Not-Dhananjay-Mishra.
LGTM.
Merging.

@gmlewis gmlewis merged commit 6617b4f into google:master Apr 17, 2026
7 of 8 checks passed
@stevehipwell stevehipwell deleted the fix-redirect-handling branch April 17, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants