chore: Switch legacy redirect handling to new pattern#4161
chore: Switch legacy redirect handling to new pattern#4161gmlewis merged 1 commit intogoogle:masterfrom
Conversation
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4161 +/- ##
==========================================
+ Coverage 93.83% 93.85% +0.01%
==========================================
Files 209 209
Lines 19685 19667 -18
==========================================
- Hits 18472 18458 -14
+ Misses 1015 1013 -2
+ Partials 198 196 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @stevehipwell!
Do we have any integration tests associated with these endpoints so that they can be validated that they functionally still work? If not, do you think this would be a good use of integration tests?
Otherwise, LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @alexandear - @zyfy29 - @Not-Dhananjay-Mishra - @munlicode
|
@gmlewis |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @stevehipwell and @Not-Dhananjay-Mishra.
LGTM.
Merging.
This PR switches the legacy redirect pattern that modifies the global client to use the new pattern introduced in #3411.
Related to #3915