Fix Python object API Pack for fixed arrays of structs#9168
Open
momomuchu wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The Python object API
Pack()code generator accessed a fixed array of structs as a single object instead of iterating its elements. For a struct field that is a fixed array of structs,Pack()raisedAttributeErroror produced wrong output.Root cause
In the Python code generator (
src/idl_gen_python.cpp), the object APIPack()code emitted a flat field access (self.d.a) for a fixed array of structs, instead of iterating the array elements.Fix
The generator now emits recursive helpers: it walks struct fields carrying an array context stack, and for a fixed array of structs it wraps each leaf field in one list comprehension per array depth, so nested fixed arrays of structs pack correctly at any depth. Scalar arrays and non array fields are unchanged. The committed generated Python test files are regenerated to match the fixed
flatcoutput.Tests
Added an object API Pack test for a fixed array of structs (Pack then read back, asserting nested values). The full Python test suite passes via
PythonTest.sh. Reverting the generator change makes the test fail withAttributeError.Fixes #9061