Handle negation in ObjectEqualsForPrimitives. - #6065
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_967399846
branch
from
August 25, 2026 21:49
45ffd49 to
876f0e9
Compare
When converting `!Objects.equals(a, b)` to use primitive equality, rewriting only the method call leaves an awkward `!(a == b)`. Inspect parent AST nodes across enclosing parentheses to detect logical negation (`!`) and replace the whole expression with `(a != b)`. PiperOrigin-RevId: 970828962
copybara-service
Bot
force-pushed
the
test_967399846
branch
from
August 25, 2026 22:18
876f0e9 to
19ed7ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle negation in ObjectEqualsForPrimitives.
When converting
!Objects.equals(a, b)to use primitive equality, rewriting only the method call leaves an awkward!(a == b). Inspect parent AST nodes across enclosing parentheses to detect logical negation (!) and replace the whole expression with(a != b).