Flag non-relational operations and unary negation on compareTo results in CompareToZero. - #6063
Merged
Merged
Conversation
…s in `CompareToZero`.
The `CompareToZero` bug pattern previously only flagged addition, subtraction, and specific comparisons on `compareTo` results. This change updates the check to flag all non-relational binary operations (including arithmetic, string concatenation, and bitwise operations) as well as unary negation (`-x.compareTo(y)`).
Specific diagnostic messages are added for arithmetic operations (clarifying `{-1, 0, +1}` range assumptions and overflow risks), unary negation, and general non-relational operations, recommending `Integer.signum`.
The check is temporarily disabled via Error Prone flags until depot violations are cleaned up.
PiperOrigin-RevId: 970134346
copybara-service
Bot
force-pushed
the
test_955519932
branch
from
August 24, 2026 22:58
fbb70a0 to
3cf3c69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flag non-relational operations and unary negation on compareTo results in
CompareToZero.The
CompareToZerobug pattern previously only flagged addition, subtraction, and specific comparisons oncompareToresults. This change updates the check to flag all non-relational binary operations (including arithmetic, string concatenation, and bitwise operations) as well as unary negation (-x.compareTo(y)).Specific diagnostic messages are added for arithmetic operations (clarifying
{-1, 0, +1}range assumptions and overflow risks), unary negation, and general non-relational operations, recommendingInteger.signum.The check is temporarily disabled via Error Prone flags until depot violations are cleaned up.