fix(artifacts): Preserve inline_data display_name on artifact load#5854
Open
kkj333 wants to merge 1 commit into
Open
fix(artifacts): Preserve inline_data display_name on artifact load#5854kkj333 wants to merge 1 commit into
kkj333 wants to merge 1 commit into
Conversation
File and GCS artifact services dropped inline_data.display_name after save/load, so clients saw generic attachment names instead of user-facing filenames. Persist display_name in file metadata and GCS blob metadata, then restore it when rebuilding binary Parts. Fixes google#5833
rohityan
added
the
services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inline_data.display_namewhen saving binary artifacts toFileArtifactService(metadata.json) andGcsArtifactService(blob metadata)display_namewhen loading binary artifacts so user-facing filenames round-trip through durable storageFixes #5833
Test plan
uv run pytest tests/unittests/artifacts/test_artifact_service.py -q(62 passed)FileArtifactServicenow returnsdisplay_name='My Report (final).png'after save/load (wasNone)