Skip to content

fix: sanitize GCS blob names to prevent path traversal in skill loading #5281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BISHT-CX wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: sanitize GCS blob names to prevent path traversal in skill loading #5281

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4efa502
Enhance security in blob path normalization
BISHT-CX Apr 11, 2026
80d9210
Fix indentation in _load_files_in_dir function
BISHT-CX Apr 11, 2026
83b21a9
Fix indentation in _load_files_in_dir function
BISHT-CX Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/google/adk/skills/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"""Utility functions for Agent Skills."""

from __future__ import annotations

import os
import logging
import pathlib
from typing import Union
Expand Down Expand Up @@ -407,10 +407,17 @@ def _load_files_in_dir(subdir: str) -> Dict[str, Union[str, bytes]]:
result = {}

for blob in blobs:
relative_path = blob.name[len(prefix) :]
relative_path = blob.name[len(prefix):]
if not relative_path:
continue

# Prevent path traversal via malicious GCS blob names
normalized = os.path.normpath(relative_path)
if normalized.startswith('..') or os.path.isabs(normalized):
raise ValueError(
f"Unsafe path in skill resource: {relative_path!r}"
)

try:
result[relative_path] = blob.download_as_text()
except UnicodeDecodeError:
Expand Down