feat(sessions): introduce pluggable SessionDataTransformer hooks for …#5280
Open
sgmoorthy wants to merge 1 commit intogoogle:mainfrom
Open
feat(sessions): introduce pluggable SessionDataTransformer hooks for …#5280sgmoorthy wants to merge 1 commit intogoogle:mainfrom
sgmoorthy wants to merge 1 commit intogoogle:mainfrom
Conversation
…masking in DatabaseSessionService
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
Saving sensitive strings, tokens, and identifiers (e.g. LLM inputs) inherently places unencrypted PII straight into the database table JSON schema. The current
DatabaseSessionServicepersists bare event payloads and state natively without an option to selectively redact or encrypt content prior to database ingestion.Solution:
Exposes a
transformer: Optional[SessionDataTransformer] = Noneargument inDatabaseSessionService. It adopts a formal Protocol containing 4 hook strategies ([before|after]_[persist|load]_[event|state]), allowing customized tokenizations, field-level encryption, or redactions natively. This process reliably isolates raw database serialization blocks and keeps caller memory safely un-mutated, protecting local state access while securely scrubbing the storage records.Testing Plan
Unit Tests:
Unit Test Summary:
4 additional tests successfully verified
StorageEventbehaviors using aMockPIIMaskerTransformer. Assertions validated JSON mappings cleanly tokenizing strings (e.g.foo->foo_masked) strictly in SQL layers while raising programmatic failures correctly on bad schemas. All existing legacy unittests successfully passed locally alongside it.Manual End-to-End (E2E) Tests:
I verified tokenizations correctly function within live applications via the standard Python initialization methodology:
Setup Script:
Logs/Evidence:
(The generated SQLite verification successfully proved backend storage intercepts
[REDACTED_NAME], while the caller runtime session objects simultaneously retrieved standardJohn Doestrings).Checklist
Additional context
Built and installed the local configuration to a clean isolated environment using
uv buildanduv venvto guarantee python wheel module imports operated effectively. All legacy instantiations gracefully default to backwards-compatible structures.