Skip to content

fix(models): register gemma 4 model names#5158

Closed
pandego wants to merge 3 commits intogoogle:mainfrom
pandego:fix/5156-gemma4-registry
Closed

fix(models): register gemma 4 model names#5158
pandego wants to merge 3 commits intogoogle:mainfrom
pandego:fix/5156-gemma4-registry

Conversation

@pandego
Copy link
Copy Markdown

@pandego pandego commented Apr 4, 2026

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

2. Or, if no issue exists, describe the change:

Problem:
LLMRegistry only matched gemma-3.*, so string model names like gemma-4-31b-it were rejected even though the underlying Gemini-backed Gemma path already supports them.

Solution:
Broaden Gemma.supported_models() to match the full gemma-* family and add a registry regression test covering Gemma 3 plus Gemma 4 model names.

Testing Plan

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Passed locally:

  • uv sync --extra test
  • uv run pytest tests/unittests/models/test_models.py tests/unittests/models/test_gemma_llm.py

Manual End-to-End (E2E) Tests:

Not run for this focused registry fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

This keeps the fix narrowly scoped to registry matching. It does not change Gemma request handling itself.

@adk-bot adk-bot added the models [Component] Issues related to model support label Apr 4, 2026
@rohityan rohityan self-assigned this Apr 6, 2026
@rohityan rohityan added the request clarification [Status] The maintainer need clarification or more information from the author label Apr 13, 2026
@rohityan rohityan added needs review [Status] The PR/issue is awaiting review from the maintainer and removed request clarification [Status] The maintainer need clarification or more information from the author labels Apr 13, 2026
@rohityan
Copy link
Copy Markdown
Collaborator

Hi @pandego , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share.

@rohityan rohityan removed the needs review [Status] The PR/issue is awaiting review from the maintainer label Apr 13, 2026
@rohityan
Copy link
Copy Markdown
Collaborator

Hi @pandego , closing this since it has been fixed in this commit (9d4ecbe)

@rohityan rohityan closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

models [Component] Issues related to model support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gemma 4 not registered in LLMRegistry — Gemma.supported_models() only matches gemma-3.*

3 participants