feat(gemma4): support Gemma4 in Gemini#5117
Open
douglas-reid wants to merge 2 commits intogoogle:mainfrom
Open
feat(gemma4): support Gemma4 in Gemini#5117douglas-reid wants to merge 2 commits intogoogle:mainfrom
douglas-reid wants to merge 2 commits intogoogle:mainfrom
Conversation
Collaborator
|
Hi @douglas-reid , Thank you for your contribution through this pull request! This PR has merge conflicts that require changes from your end. Could you please rebase your branch with the latest main branch to address these? Once this is complete, please let us know so we can proceed with the review. |
Contributor
Author
Should be done now. Please let me know if more is needed. |
- Update docstrings for Gemma, Gemma3Ollama, and GemmaFunctionCallingMixin to clarify they are Gemma 3-only - Add Gemma 4 usage guidance pointing to Gemini/LiteLlm classes - Add hello_world_gemma4 sample using standard Gemini class - Add header comments and READMEs to existing Gemma 3 samples - Add registry non-collision test for Gemma 4 model strings - Update registration comments in models/__init__.py
51851ba to
c4489eb
Compare
c4489eb to
eae4c1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main intent of this PR is to clarify Gemma 3 classes and add Gemma 4 sample now that Gemma 4 is released. As part of that work, this PR adds
gemma-4-*to the allowlist for Gemini models for use in ADK.This PR:
gemma-4-*to the allowlist for Gemini modelsTesting Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.Manual End-to-End (E2E) Tests:
Ran
adk run contributing/samples/hello_world_gemma4with successChecklist
Additional context