Replace old model gemini-2.0 references by 2.5#4705
Replace old model gemini-2.0 references by 2.5#4705morganroux wants to merge 5 commits intogoogle:mainfrom
Conversation
adk-bot
added
core
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates all references to the 'gemini-2.0-flash' model to 'gemini-2.5-flash' throughout the project. This ensures that the codebase aligns with the latest available model, addressing a discrepancy where an older, deprecated model was still being referenced in various configurations and tests. The change impacts agent definitions, configuration schemas, utility functions, and a comprehensive suite of tests, promoting better model utilization and consistency. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
morganroux
force-pushed
the
fix/issues/4666
branch
from
f426cf6 to
dbe4d19
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the model name from gemini-2.0-flash to gemini-2.5-flash across the codebase, including documentation, configuration files, and tests. The changes are mostly straightforward replacements. I've found one minor issue in a test file where this change introduces a duplicate entry in a list, which I've commented on. Otherwise, the changes look good and align with the goal of phasing out the older model.
Note: Security Review did not run due to the size of the PR.
I am having trouble creating individual review comments. Click here to see my feedback.
tests/unittests/tools/test_google_search_tool.py (421)
This change introduces a duplicate entry for 'gemini-2.5-flash' in the gemini_2_models list, as it's already present on line 423. While this doesn't break the test, it's redundant. For better code clarity, you could remove the duplicate entry. The list could be simplified to ['gemini-2.0-pro', 'gemini-2.5-flash', 'gemini-2.5-pro'].
morganroux
changed the title
|
Hi @morganroux , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
rohityan
added
needs review
|
Hi @ankursharmas , can you please review this. |
wuliang229
added
the
ready to pull
Merge #4705 ### Link to Issue or Description of Change - Closes: #4666 **Problem:** Gemini-2.0-flash model is still used in integration tests, but disabled for new users **Solution:** Replace all occurrences of Gemini-2.0-flash by Gemini-2.5-flash, in integration tests and docstrings. Because gemini-2.0 is still enabled for some users, this PR doesn't clean the model from unit tests. ### Testing Plan Run already existing unittests and integration tests ### Checklist - [x] I have read the [CONTRIBUTING.md](https://github.com/google/adk-python/blob/main/CONTRIBUTING.md) document. - [x] I have performed a self-review of my own code. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have added tests that prove my fix is effective or that my feature works. - [x] New and existing unit tests pass locally with my changes. - [x] I have manually tested my changes end-to-end. - [x] Any dependent changes have been merged and published in downstream modules. COPYBARA_INTEGRATE_REVIEW=#4705 from morganroux:fix/issues/4666 3c390a2 PiperOrigin-RevId: 900973552
|
Thank you @morganroux for your contribution! 🎉 Your changes have been successfully imported and merged via Copybara in commit 110aecf. Closing this PR as the changes are now in the main branch. |
Merge #4705 ### Link to Issue or Description of Change - Closes: #4666 **Problem:** Gemini-2.0-flash model is still used in integration tests, but disabled for new users **Solution:** Replace all occurrences of Gemini-2.0-flash by Gemini-2.5-flash, in integration tests and docstrings. Because gemini-2.0 is still enabled for some users, this PR doesn't clean the model from unit tests. ### Testing Plan Run already existing unittests and integration tests ### Checklist - [x] I have read the [CONTRIBUTING.md](https://github.com/google/adk-python/blob/main/CONTRIBUTING.md) document. - [x] I have performed a self-review of my own code. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have added tests that prove my fix is effective or that my feature works. - [x] New and existing unit tests pass locally with my changes. - [x] I have manually tested my changes end-to-end. - [x] Any dependent changes have been merged and published in downstream modules. COPYBARA_INTEGRATE_REVIEW=#4705 from morganroux:fix/issues/4666 3c390a2 PiperOrigin-RevId: 900973552 Change-Id: I1d2dd4c749522b529537d5863e4a56865927da95
4 participants
Link to Issue or Description of Change
Problem:
Gemini-2.0-flash model is still used in integration tests, but disabled for new users
Solution:
Replace all occurrences of Gemini-2.0-flash by Gemini-2.5-flash, in integration tests and docstrings.
Because gemini-2.0 is still enabled for some users, this PR doesn't clean the model from unit tests.
Testing Plan
Run already existing unittests and integration tests
Checklist