Fix tests#102
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the model ID to gemini-2.5-flash and removes the explicit environment variable check for GEMINI_API_KEY in javascript/grounding.js. Feedback indicates that removing this validation reduces the robustness of the example and could lead to inconsistent behavior or confusing error messages if the required environment variable is missing.
I am having trouble creating individual review comments. Click here to see my feedback.
javascript/grounding.js (21-23)
Removing the explicit environment variable check reduces the robustness of the example and potentially contradicts the stated goal of standardizing on GEMINI_API_KEY. Without this validation, if GEMINI_API_KEY is missing, the SDK may fall back to looking for GOOGLE_API_KEY in the environment or attempt to use Application Default Credentials, leading to inconsistent behavior and confusing error messages for users. Maintaining a clear 'API key not set' error is a best practice for developer experience in example code.
|
Ignore the failed environmental errors in this PR, I'm shutting that down. Actual tests are tracked in: https://github.com/google-gemini/api-examples/actions/runs/25146625460 and some have genuine failures that are being fixed in #101. |
…y don't fail on MAX_TOKENS" This reverts commit 66d6d06.
Fix tests across all languages
Also removing the "environment" setup, it's too much overhead. Using maintainer-approval button to kick off tests instead.
There are some failing tests that should be corrected in #101.