Skip to content

feat(gooddata-sdk): [AUTO] Add grandTotalsPosition field to tabular export Settings schema #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yenkins-admin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(gooddata-sdk): [AUTO] Add grandTotalsPosition field to tabular export Settings schema #1575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/gooddata-sdk/src/gooddata_sdk/catalog/export/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

from gooddata_sdk.catalog.base import Base

GrandTotalsPosition = Literal["pinnedBottom", "pinnedTop", "bottom", "top"]
GrandTotalsPosition = Literal["pinnedBottom", "pinnedTop", "bottom", "top", "TOP", "BOTTOM"]


@define(kw_only=True)
Expand Down
2 changes: 1 addition & 1 deletion packages/gooddata-sdk/tests/export/test_export_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def _tabular_by_visualization_id_base(test_config, export_format: str):

@pytest.mark.parametrize(
"grand_totals_position",
["pinnedBottom", "pinnedTop", "bottom", "top"],
["pinnedBottom", "pinnedTop", "bottom", "top", "TOP", "BOTTOM"],
)
def test_export_settings_grand_totals_position(grand_totals_position):
settings = ExportSettings(merge_headers=True, show_filters=False, grand_totals_position=grand_totals_position)
Expand Down
Loading