feat(gooddata-sdk): [AUTO] Remove AAC analytics model endpoints and AacAnalyticsModel schemas#1573
Open
yenkins-admin wants to merge 3 commits intomasterfrom
Open
feat(gooddata-sdk): [AUTO] Remove AAC analytics model endpoints and AacAnalyticsModel schemas#1573yenkins-admin wants to merge 3 commits intomasterfrom
yenkins-admin wants to merge 3 commits intomasterfrom
Conversation
…acAnalyticsModel schemas
jaceksan
requested changes
Apr 20, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1573 +/- ##
===========================================
+ Coverage 0.00% 77.76% +77.76%
===========================================
Files 158 230 +72
Lines 11048 15392 +4344
===========================================
+ Hits 0 11969 +11969
+ Misses 11048 3423 -7625 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Review fixes appliedAddressed feedback from @jaceksan in Workflow run • Claude output available in workflow artifacts |
jaceksan
requested changes
Apr 20, 2026
Contributor
jaceksan
left a comment
There was a problem hiding this comment.
Overall PR is wrong, IMHO.
Context:
- I introduced AAC backend APIs
- I realized it is not maintable
- I introduced a Python package published from UI repo where AAC logic is mastered(so called SDK convertors). I adopted it in this repository. This must not be removed.
The only thing related to backend AAC APIs delivered to this repo should be OpenAPI client (generated), which was regenerated, so AAC should not be there, right?
Am I right that no code should be changed in this case?
Contributor
Author
Review fixes appliedAddressed feedback from @jaceksan in Workflow run • Claude output available in workflow artifacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added DeprecationWarning to all public AAC-related functions in gooddata-sdk. The AAC analytics model API endpoints (/api/v1/aac/...) have been removed from the GoodData platform, so the corresponding SDK conversion utilities (aac.py) and configuration class (AacConfig) are now soft-deprecated. All 17 public functions in aac.py and the AacConfig class emit DeprecationWarning on use. No code was removed—backward-compatible soft deprecation only.
Impact: deprecation | Services:
gooddata-metadata-clientFiles changed
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/aac.pypackages/gooddata-sdk/src/gooddata_sdk/config.pyAgent decisions
Decisions (4)
soft deprecation vs removal — Add DeprecationWarning to all public AAC functions and AacConfig; keep implementation intact
deprecation message constant placement — Module-level _AAC_DEPRECATION_MSG constant defined after all imports in aac.py
AacConfig deprecation mechanism — Use attrs_post_init to emit DeprecationWarning on every instantiation
stacklevel for all deprecated functions — stacklevel=2 pointing one level up from the deprecated function call
Assumptions to verify (3)
Risks (1)
Layers touched (1)
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/aac.pypackages/gooddata-sdk/src/gooddata_sdk/config.pySource commits (gdc-nas)
3f12bfeMerge pull request #21422 from gooddata/jacek/aidaad2e512Merge pull request #21229 from gooddata/jacek/aida-artifacts-v2206b304Merge pull request #22202 from gooddata/jacek/replace-aida-with-native-agents-mdOpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow