feat(gooddata-sdk): [AUTO] Add WidgetDescriptor, DashboardContext, UIContext schemas; extend UserContext#1558
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
Conversation
…Context schemas; extend UserContext
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1558 +/- ##
==========================================
+ Coverage 78.66% 78.76% +0.09%
==========================================
Files 230 231 +1
Lines 15405 15505 +100
==========================================
+ Hits 12118 12212 +94
- Misses 3287 3293 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added SDK wrapper models for WidgetDescriptor, DashboardContext, UIContext, ObjectReference, ObjectReferenceGroup, and the extended UserContext (with referencedObjects and view). Updated ai_chat/ai_chat_stream to accept optional CatalogUserContext. Exported all new classes from init.py. Unit tests added for all new model serialization paths.
Impact: new_feature | Services:
gooddata-afm-clientTickets: LX-2141
Files changed
packages/gooddata-sdk/src/gooddata_sdk/compute/model/user_context.pypackages/gooddata-sdk/src/gooddata_sdk/compute/service.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/compute/test_user_context.pyAgent decisions
Decisions (5)
model location — Placed all new models in packages/gooddata-sdk/src/gooddata_sdk/compute/model/user_context.py
widget descriptor polymorphism — Three independent @attrs.define classes unified via Union TypeAlias CatalogWidgetDescriptor
Union alias import style — from typing import Union used for the CatalogWidgetDescriptor alias
as_api_model() vs Base.to_api() — Explicit as_api_model() on each model without extending Base
referenced_objects omission when empty — Omit referenced_objects from UserContext API model when list is empty
Assumptions to verify (3)
Risks (1)
Layers touched (3)
packages/gooddata-sdk/src/gooddata_sdk/compute/model/user_context.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/src/gooddata_sdk/compute/service.pypackages/gooddata-sdk/tests/compute/test_user_context.pySource commits (gdc-nas)
3f2b607Merge pull request #21274 from gooddata/smac/LX-214163dd6bffeat(gen-ai): refactor widgets polymorphism and enhance OpenAPI spec075d22dMerge pull request #21389 from gooddata/dho/trivial-fixOpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow