feat(gooddata-sdk): [AUTO] Add retrieveResultBinary endpoint; remove Arrow formats from retrieveResult#1557
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
Conversation
…Arrow formats from retrieveResult
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1557 +/- ##
=======================================
Coverage 78.66% 78.66%
=======================================
Files 230 230
Lines 15405 15407 +2
=======================================
+ Hits 12118 12120 +2
Misses 3287 3287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
Execution.read_result_arrow()method to the SDK'sExecutionclass, delegating to the already-implementedBareExecutionResponse.read_result_arrow(). Also added two new unit tests that exercise the delegation path throughExecution. No other layers needed changes: the API client already hadretrieve_result_binary,BareExecutionResponse.read_result_arrow()was already implemented and tested, and all relevant classes were already exported fromgooddata_sdk/__init__.py.Impact: new_feature | Services:
gooddata-afm-clientFiles changed
packages/gooddata-sdk/src/gooddata_sdk/compute/model/execution.pypackages/gooddata-sdk/tests/compute/test_bare_execution_response.pyAgent decisions
Decisions (3)
where to expose read_result_arrow() — Add read_result_arrow() to Execution as a thin delegation to bare_exec_response.read_result_arrow()
not adding a new service method on ComputeService — No ComputeService change; the binary read is per-execution, not a standalone service call
not modifying init.py — No changes to public exports
Assumptions to verify (3)
Risks (2)
Layers touched (2)
packages/gooddata-sdk/src/gooddata_sdk/compute/model/execution.pypackages/gooddata-sdk/tests/compute/test_bare_execution_response.pySource commits (gdc-nas)
81eb97aMerge pull request #21382 from gooddata/dho/cq-104-arrow-api-2OpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow