feat(gooddata-sdk): [AUTO] Add ToolCallEventResult schema and toolCallEvents to chat response#1556
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] Add ToolCallEventResult schema and toolCallEvents to chat response#1556yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…lEvents to chat response
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1556 +/- ##
==========================================
+ Coverage 78.66% 78.68% +0.02%
==========================================
Files 230 231 +1
Lines 15405 15421 +16
==========================================
+ Hits 12118 12134 +16
Misses 3287 3287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
ToolCallEventResultSDK wrapper class for the newToolCallEventResultOpenAPI schema and thetoolCallEventsarray field added toChatResult. The generated API client already contained both changes; the SDK wrapper was added incompute/model/chat.pyand exported fromgooddata_sdk/__init__.py. A unit test covering construction,from_dict/to_dictround-trip, andclient_class()was added intests/compute/test_chat_models.py.Impact: new_feature | Services:
gooddata-afm-clientTickets: GDAI-1438
Files changed
packages/gooddata-sdk/src/gooddata_sdk/compute/model/chat.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/compute/test_chat_models.pyAgent decisions
Decisions (3)
Class placement — Placed ToolCallEventResult in compute/model/chat.py (compute module, no Catalog prefix)
Naming to avoid collision with generated client — Import generated class as ApiToolCallEventResult alias, define SDK class as ToolCallEventResult
Wrapper vs. pass-through — Created a proper attrs wrapper class extending Base
Assumptions to verify (3)
Risks (1)
Layers touched (3)
packages/gooddata-sdk/src/gooddata_sdk/compute/model/chat.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/compute/test_chat_models.pySource commits (gdc-nas)
0e847c5Merge pull request #21287 from gooddata/zovi/GDAI-1438-e2e-skill-testsOpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow