feat(gooddata-sdk): [AUTO] Add resolveLlmProviders endpoint and ResolvedLlm polymorphic schemas#1554
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] Add resolveLlmProviders endpoint and ResolvedLlm polymorphic schemas#1554yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…vedLlm polymorphic schemas
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1554 +/- ##
==========================================
+ Coverage 78.66% 78.68% +0.01%
==========================================
Files 230 231 +1
Lines 15405 15465 +60
==========================================
+ Hits 12118 12168 +50
- Misses 3287 3297 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added SDK wrapper for the new
resolveLlmProvidersGET endpoint (/api/v1/actions/workspaces/{workspaceId}/ai/resolveLlmProviders). Created four new model classes (CatalogResolvedLlms, CatalogResolvedLlmEndpoint, CatalogResolvedLlmProvider, CatalogResolvedLlmModelItem) in a new entity_model file, added resolve_llm_providers() service method to CatalogWorkspaceContentService, exported all new classes from gooddata_sdk/init.py, and added pure-unit tests covering the polymorphic parsing logic.Impact: new_feature | Services:
gooddata-afm-clientFiles changed
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/entity_model/resolved_llm.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/content_service.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/test_resolved_llm.pyAgent decisions
Decisions (4)
Service method placement — Added resolve_llm_providers() to CatalogWorkspaceContentService
Polymorphic oneOf parsing (endpoint vs provider) — Check for presence of the 'models' key in the raw data dict to dispatch to CatalogResolvedLlmProvider vs CatalogResolvedLlmEndpoint
client_class() with deferred imports — Lazy-import generated client classes inside client_class() static methods to avoid circular imports at module load time
Test type: unit vs integration — Pure unit tests (no mocks, no cassettes)
Assumptions to verify (3)
Risks (2)
Layers touched (3)
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/entity_model/resolved_llm.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/content_service.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/test_resolved_llm.pySource commits (gdc-nas)
699c75cMerge pull request #21420 from hkad98/jkd/resolve-llm-providerOpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow