Skip to content

feat(gooddata-sdk): [AUTO] Add HYPERLOGLOG enum to attribute label and value type enums#1553

Closed
yenkins-admin wants to merge 1 commit intomasterfrom
auto/openapi-sync-C001-20260419-r49222
Closed

feat(gooddata-sdk): [AUTO] Add HYPERLOGLOG enum to attribute label and value type enums#1553
yenkins-admin wants to merge 1 commit intomasterfrom
auto/openapi-sync-C001-20260419-r49222

Conversation

@yenkins-admin
Copy link
Copy Markdown
Contributor

Summary

Added HYPERLOGLOG to the GoodDataLabelType enum in packages/gooddata-dbt/src/gooddata_dbt/dbt/base.py. The gooddata-sdk wrapper itself uses plain str for value_type and label_type fields, so no changes are needed there. The only hand-written SDK code that enumerates these values is the GoodDataLabelType Python Enum used by the dbt integration.

Impact: enum_addition | Services: gooddata-afm-client, gooddata-metadata-client

Files changed

  • packages/gooddata-dbt/src/gooddata_dbt/dbt/base.py

Agent decisions

Decisions (2)

scope of enum update — Update only GoodDataLabelType in gooddata-dbt; leave gooddata-sdk str fields unchanged

  • Alternatives: Add a Literal TypeAlias in gooddata-sdk/catalog/types.py, Add validation in CatalogDeclarativeLabel.as_api_model()
  • Why: gooddata-sdk's CatalogDeclarativeLabel.value_type and CatalogLabel.value_type are typed as str | None and pass values through without validation. gooddata-dbt's GoodDataLabelType is the only hand-written enum that explicitly lists allowed API values, so it is the only file requiring the addition.

whether to backfill missing GEO and IMAGE — Add only HYPERLOGLOG; leave GEO and IMAGE absent from GoodDataLabelType

  • Alternatives: Backfill all missing enum values for completeness
  • Why: The diff introduces only HYPERLOGLOG. GEO and IMAGE were already absent before this change; adding them would be out of scope for this cluster.
Assumptions to verify (3)
  • gooddata-dbt is in scope for this task — the workspace layout description of 'gooddata-sdk/' is interpreted broadly to include all hand-written SDK packages under packages/
  • The GoodDataLabelType enum is used only by the dbt integration to validate dbt YAML label_type values; it does not gate API serialization in gooddata-sdk proper
  • HYPERLOGLOG is not expected to appear in the dbt test fixtures (manifest.json), so no fixture updates are needed
Risks (1)
  • None — this is a pure enum addition; no serialization logic or cassette recordings are affected
Layers touched (1)
  • entity_model — GoodDataLabelType enum in dbt base module mirrors the API labelType/valueType enum; HYPERLOGLOG added
    • packages/gooddata-dbt/src/gooddata_dbt/dbt/base.py

Source commits (gdc-nas)

  • 6faf4e2 Merge pull request #21484 from pcerny/pce/cq-2118_hll_sr
OpenAPI diff
diff --git a/microservices/afm-exec-api/src/test/resources/openapi/open-api-spec.json b/microservices/afm-exec-api/src/test/resources/openapi/open-api-spec.json
@@ -623,7 +623,7 @@
               "valueType" : {
                 "description" : "Attribute value type.",
-                "enum" : [ "TEXT", "HYPERLINK", "GEO", "GEO_LONGITUDE", "GEO_LATITUDE", "GEO_AREA", "GEO_ICON", "IMAGE" ],
+                "enum" : [ "TEXT", "HYPERLINK", "GEO", "GEO_LONGITUDE", "GEO_LATITUDE", "GEO_AREA", "GEO_ICON", "IMAGE", "HYPERLOGLOG" ],
                 "type" : "string"
@@ -2553,7 +2553,7 @@
           "valueType" : {
-            "enum" : [ "TEXT", "HYPERLINK", "GEO", "GEO_LONGITUDE", "GEO_LATITUDE", "GEO_AREA", "GEO_ICON", "IMAGE" ],
+            "enum" : [ "TEXT", "HYPERLINK", "GEO", "GEO_LONGITUDE", "GEO_LATITUDE", "GEO_AREA", "GEO_ICON", "IMAGE", "HYPERLOGLOG" ],
diff --git a/microservices/metadata-api/src/test/resources/openapi/open-api-spec.json b/microservices/metadata-api/src/test/resources/openapi/open-api-spec.json
@@ -4456,7 +4456,7 @@
           "labelType" : {
             "description" : "Label type for the target attribute.",
-            "enum" : [ "TEXT", "HYPERLINK", "GEO", "GEO_LONGITUDE", "GEO_LATITUDE", "GEO_AREA", "GEO_ICON", "IMAGE" ],
+            "enum" : [ "TEXT", "HYPERLINK", "GEO", "GEO_LONGITUDE", "GEO_LATITUDE", "GEO_AREA", "GEO_ICON", "IMAGE", "HYPERLOGLOG" ],
@@ -6692,7 +6692,7 @@
           "valueType" : {
-            "enum" : [ "TEXT", "HYPERLINK", "GEO", "GEO_LONGITUDE", "GEO_LATITUDE", "GEO_AREA", "GEO_ICON", "IMAGE" ],
+            "enum" : [ "TEXT", "HYPERLINK", "GEO", "GEO_LONGITUDE", "GEO_LATITUDE", "GEO_AREA", "GEO_ICON", "IMAGE", "HYPERLOGLOG" ],
@@ -16536,7 +16536,7 @@
               "valueType" : {
-                "enum" : [ "TEXT", "HYPERLINK", "GEO", "GEO_LONGITUDE", "GEO_LATITUDE", "GEO_AREA", "GEO_ICON", "IMAGE" ],
+                "enum" : [ "TEXT", "HYPERLINK", "GEO", "GEO_LONGITUDE", "GEO_LATITUDE", "GEO_AREA", "GEO_ICON", "IMAGE", "HYPERLOGLOG" ],

Workflow run


Generated by SDK OpenAPI Sync workflow

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.66%. Comparing base (37d0593) to head (e1996f7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1553   +/-   ##
=======================================
  Coverage   78.66%   78.66%           
=======================================
  Files         230      230           
  Lines       15405    15406    +1     
=======================================
+ Hits        12118    12119    +1     
  Misses       3287     3287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tychtjan tychtjan closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants