feat(gooddata-sdk): [AUTO] Add filter_context to ObjectType enum in gen-ai#1549
Closed
yenkins-admin wants to merge 2 commits intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] Add filter_context to ObjectType enum in gen-ai#1549yenkins-admin wants to merge 2 commits intomasterfrom
yenkins-admin wants to merge 2 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1549 +/- ##
=======================================
Coverage 78.66% 78.66%
=======================================
Files 230 230
Lines 15405 15405
=======================================
Hits 12118 12118
Misses 3287 3287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The implement agent writes its message log to transcript-implement-C016.jsonl. This file was accidentally committed by 'git add -A' in the deliver step of sdk-py-openapi-sync.yml (gdc-nas). The workflow has been patched to write transcripts outside the sdk/ checkout so future auto-PRs won't contain them. Attempted to do this via the review-fix workflow as a first-run test of that pipeline; the agent correctly identified the file but the security hook blocks all file deletion primitives (git rm, os.remove, etc.) — that is by design for the review-fix scope, so needs_manual fell through to here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added "filter_context" to the ObjectType enum documentation in the search_ai() method docstring in compute/service.py. The OpenAPI diff adds filter_context as a valid ObjectType enum value in the gen-ai service. The only SDK wrapper change needed was updating the docstring that lists the valid enum values, since the method already accepts list[str] without additional SDK-level validation.
Impact: enum_addition | Services:
gen-aiFiles changed
packages/gooddata-sdk/src/gooddata_sdk/compute/service.pyAgent decisions
Decisions (1)
scope of change — Docstring-only update in compute/service.py
Assumptions to verify (2)
Layers touched (1)
packages/gooddata-sdk/src/gooddata_sdk/compute/service.pySource commits (gdc-nas)
78f7152feat(gen-ai): refactor metadata generation and filter handling (#21356)OpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow