fix(deploy): activate the release and application after deploy (DEVX-539)#99
Closed
smukherjee-godaddy wants to merge 1 commit into
Closed
Conversation
…539) `application deploy` uploaded extension artifacts but never activated anything, so every deployed app stayed INACTIVE and could not be enabled — the core deploy workflow was effectively a no-op. Ports the TS deploy behavior (PR godaddy#77). - ApplicationClient: add activate_release(applicationId, releaseId) mirroring the ActivateRelease GraphQL mutation - deploy_command: after the extension loop (regardless of extension count) call activate_release then update_application(status: ACTIVE), streaming release.activate / application.activate step events - test: httpmock coverage that activate_release sends both IDs and returns data Note: the full deploy-flow integration test (T1) is deferred to the test-layer ticket; this covers the new client method directly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing as superseded by #103, which has already merged the same release activation and application promotion flow into rust-port with broader client-level test coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
gddy application deploybundled and uploaded extension artifacts but never activated anything — it ended after the extension loop. As a result every app deployed with the Rust CLI stayed INACTIVE and could not be enabled, so a deploy was effectively a no-op. Broken for both the extension path and the no-extension path.Fix
Ports the TS deploy behavior (PR #77):
ApplicationClient— addactivate_release(applicationId, releaseId), mirroring theActivateReleaseGraphQL mutation ($applicationId: ID!, $releaseId: ID!).deploy_command— after the extension loop and regardless of extension count, callactivate_releasethenupdate_application(status: ACTIVE), streamingrelease.activateandapplication.activatestep events, and reportingstatus_after: ACTIVEon the terminaldeploystep.Order matters: the release is activated before the application is set ACTIVE.
Impact
Testing
httpmocktest:activate_releasesends both IDs and returns the response data.cargo test/cargo clippy --all-targets -- -D warnings/cargo fmt --check— all clean.Context
Part of the Track A "ship an app" golden path. The terminal streaming
result/errorevent fordeploy --follow(DEVX-544) builds on this activation step.